deniskuzZ commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r760238917
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -172,22 +174,29 @@ private void clean(CompactionInfo ci, long minOpenTxnGLB,
boolean metricsEnabled
if (metricsEnabled) {
perfLogger.perfLogBegin(CLASS_NAME, cleanerMetric);
}
- Table t = resolveTable(ci);
- if (t == null) {
- // The table was dropped before we got around to cleaning it.
- LOG.info("Unable to find table " + ci.getFullTableName() + ", assuming
it was dropped." +
+ String location =
Optional.ofNullable(ci.properties).map(StringableMap::new)
Review comment:
we only support this feature for acid tables with a non-customized
location:
````
if (!TableType.VIRTUAL_VIEW.toString().equals(tbl.getTableType())) {
if (tbl.getSd().getLocation() == null ||
tbl.getSd().getLocation().isEmpty()) {
tblPath = wh.getDefaultTablePath(db,
getPathWithSuffix(tbl.getTableName(), tbl), isExternal(tbl));
}
String getPathWithSuffix(String path, Table tbl) {
return path + (tbl.isSetTxnId() ?
VISIBILITY_PREFIX + String.format(DELTA_DIGITS, tbl.getTxnId()) :
"");
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
