marton-bod commented on a change in pull request #2847:
URL: https://github.com/apache/hive/pull/2847#discussion_r764715611
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergCTAS.java
##########
@@ -88,6 +89,35 @@ public void testCTASPartitionedFromHiveTable() throws
TException, InterruptedExc
Assert.assertEquals("name", table.spec().fields().get(1).name());
}
+ @Test
+ public void testCTASTblPropsAndLocationClause() throws Exception {
+ Assume.assumeTrue(HiveIcebergSerDe.CTAS_EXCEPTION_MSG, testTableType ==
TestTables.TestTableType.HIVE_CATALOG);
+
+ shell.executeStatement("CREATE TABLE source (id bigint, name string)
PARTITIONED BY (dept string) STORED AS ORC");
+ shell.executeStatement(testTables.getInsertQuery(
+ HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS,
TableIdentifier.of("default", "source"), false));
+
+ String location = temp.newFolder().toURI().toString();
+ shell.executeStatement(String.format(
Review comment:
This new test contains the user-added location clause: `LOCATION '%s'`
The earlier CTAS tests contain tests without the location clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
