marton-bod commented on a change in pull request #2847:
URL: https://github.com/apache/hive/pull/2847#discussion_r764725069
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -166,22 +167,33 @@ private void createTableForCTAS(Configuration
configuration, Properties serDePro
serDeProperties.put(InputFormatConfig.PARTITION_SPEC,
PartitionSpecParser.toJson(spec));
}
+ // clean up the properties for table creation (so that internal serde
props don't become table props)
+ Properties createProps = getCTASTableCreationProperties(serDeProperties);
Review comment:
I mainly extracted into a function for readability this time, not reuse.
But if you think it's better to inline, I can do it as I don't feel strongly
about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
