pvary commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r773107563



##########
File path: 
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -363,8 +366,14 @@ public Path getDefaultTablePath(Database db, String 
tableName, boolean isExterna
     } else {
       dbPath = getDatabaseManagedPath(db);
     }
-    return getDnsPath(
-        new Path(dbPath, 
MetaStoreUtils.encodeTableName(tableName.toLowerCase())));
+    if (!isExternal && tableName.matches("(.*)" + V_TABLE_PATTERN)) {

Review comment:
       nit: Maybe a comment, or a different String value, since this is not a 
`tableName`. This is `tablePath`? Strings are always recreated anyway, so there 
is not performance loss, but I think it would be easier to understand the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to