deniskuzZ commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r773250362
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1053,8 +1055,8 @@ public void abortTxn(AbortTxnRequest rqst) throws
NoSuchTxnException, MetaExcept
txnid = targetTxnIds.get(0);
}
- Optional<TxnType> txnType = getOpenTxnTypeAndLock(stmt, txnid);
- if (!txnType.isPresent()) {
+ TxnType txnType = getOpenTxnTypeAndLock(stmt, txnid);
Review comment:
I think, with the current code design in TxnHandler, like throwing an
Exception within a separate method (inspection won't work) this is a bit easier
to read and interpret.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
