abstractdog commented on a change in pull request #2771:
URL: https://github.com/apache/hive/pull/2771#discussion_r783006992
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
##########
@@ -499,6 +499,34 @@ public static void populateQuickStats(List<FileStatus>
fileStatus, Map<String, S
params.put(StatsSetupConst.NUM_ERASURE_CODED_FILES,
Integer.toString(numErasureCodedFiles));
}
+ public static void populateQuickStatsWithPrevStats(List<FileStatus>
fileStatus, Map<String,String> params){
Review comment:
this method has exactly the same logic as populateQuickStats except that
in this case, initial integer values are set from parameters
we should find a way to have the same logic written once: iteration on
FileStatus + setting integers back to parameters, otherwise there is a chance
that the two methods will diverge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
