abstractdog commented on a change in pull request #2771:
URL: https://github.com/apache/hive/pull/2771#discussion_r783007686



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
##########
@@ -136,6 +136,11 @@ public BasicStatsProcessor(Partish partish, BasicStatsWork 
work, HiveConf conf,
       }
     }
 
+    public boolean canTrim(){

Review comment:
       please javadoc on this method
   I struggle to understand what does "trim" mean in this context, also, a huge 
amount of conditions inside need an explanation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to