zabetak commented on a change in pull request #2991:
URL: https://github.com/apache/hive/pull/2991#discussion_r800659669



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
##########
@@ -512,6 +513,8 @@ private String toString(Map<String, String> parameters) {
         if (dpPartSpecs != null) {
           // load the list of DP partitions and return the list of partition 
specs
           list.addAll(dpPartSpecs);
+          // Reload partition metadata because another BasicStatsTask instance 
may have updated the stats.
+          list = db.getPartitionsByNames(table, 
list.stream().map(Partition::getName).collect(Collectors.toList()));

Review comment:
       This change is kind of reverting 
https://issues.apache.org/jira/browse/HIVE-15250. Obviously correctness is more 
important than performance but I am wondering if we explored other ways to fix 
the problem. 
   
   @rbalamohan since you worked on HIVE-15250 you may want to have a look into 
the changes here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to