zabetak commented on a change in pull request #2991:
URL: https://github.com/apache/hive/pull/2991#discussion_r800666998



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
##########
@@ -512,6 +513,8 @@ private String toString(Map<String, String> parameters) {
         if (dpPartSpecs != null) {
           // load the list of DP partitions and return the list of partition 
specs
           list.addAll(dpPartSpecs);
+          // Reload partition metadata because another BasicStatsTask instance 
may have updated the stats.
+          list = db.getPartitionsByNames(table, 
list.stream().map(Partition::getName).collect(Collectors.toList()));

Review comment:
       Truth is that things are a bit different here (in comparison with the 
state before HIVE-15250) in the sense that we are calling 
`getPartitionsByNames` instead of `getPartition` so if I understand well it 
will be only one call to DB and not multiple so maybe the perf overhead is not 
as important as it was in HIVE-15250.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to