kasakrisz commented on a change in pull request #2881:
URL: https://github.com/apache/hive/pull/2881#discussion_r803373480
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java
##########
@@ -399,8 +402,35 @@ private RelNode applyPartitionIncrementalRebuildPlan(
return applyPreJoinOrderingTransforms(basePlan, mdProvider,
executorProvider);
}
- return applyIncrementalRebuild(basePlan, mdProvider, executorProvider,
- HiveInsertOnlyScanWriteIdRule.INSTANCE,
HiveAggregatePartitionIncrementalRewritingRule.INSTANCE);
+ RelNode incrementalRebuildPlan = applyIncrementalRebuild(basePlan,
mdProvider, executorProvider,
+ HiveInsertOnlyScanWriteIdRule.INSTANCE,
+ HiveAggregatePartitionIncrementalRewritingRule.INSTANCE);
+
+ HepProgramBuilder program = new HepProgramBuilder();
+ generatePartialProgram(program, false, HepMatchOrder.DEPTH_FIRST,
HiveScanCostSetterRule.with(materialization));
+ incrementalRebuildPlan = executeProgram(incrementalRebuildPlan,
program.build(), mdProvider, executorProvider);
+
+ // Make a cost-based decision factoring the configuration property
+ optCluster.invalidateMetadataQuery();
+
RelMetadataQuery.THREAD_PROVIDERS.set(HiveTezModelRelMetadataProvider.DEFAULT);
+ try {
+ // Multiply by 10.0 because this config is also used in
applyAggregateInsertIncremental
+ final double factorSelectivity = HiveConf.getFloatVar(
+ conf,
HiveConf.ConfVars.HIVE_MATERIALIZED_VIEW_REBUILD_INCREMENTAL_FACTOR) * 10.0;
Review comment:
Removed the magic factor 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
