kgyrtkirk commented on a change in pull request #2881:
URL: https://github.com/apache/hive/pull/2881#discussion_r806937463
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTezModelRelMetadataProvider.java
##########
@@ -58,4 +60,24 @@
HiveRelMdPredicates.SOURCE,
JaninoRelMetadataProvider.DEFAULT)));
+ public static JaninoRelMetadataProvider with(RelOptMaterialization
materialization) {
+ return JaninoRelMetadataProvider.of(
+ ChainedRelMetadataProvider.of(
+ ImmutableList.of(
+ HiveRelMdDistinctRowCount.SOURCE,
Review comment:
can't we reuse somehow the other list(`DEFAULT`):
I think something like this could probably work:
```
public static final JaninoRelMetadataProvider DEFAULT2 =
JaninoRelMetadataProvider.of(
ChainedRelMetadataProvider.of(
ImmutableList.of(
HiveRelMdRowCount.SOURCE,
DEFAULT)));
```
this provider could probably also be moved closer to the place where its
being used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
