hsnusonic commented on a change in pull request #3028:
URL: https://github.com/apache/hive/pull/3028#discussion_r807187720
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
##########
@@ -212,26 +213,26 @@ protected void doPost(HttpServletRequest request,
HttpServletResponse response)
} else {
clientUserName = doKerberosAuth(request);
}
- } else if (HiveSamlUtils.isSamlAuthMode(authType)) {
Review comment:
Yes, it is changed to use `authType.isEnabled()`. I didn't delete
`HiveSamlUtils.isSamlAuthMode` in this patch because it is used in
`ThriftHttpCLIService` and that would require more changes. We should
eventually retire this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
