nrg4878 commented on a change in pull request #3028:
URL: https://github.com/apache/hive/pull/3028#discussion_r807000626
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
##########
@@ -212,26 +213,26 @@ protected void doPost(HttpServletRequest request,
HttpServletResponse response)
} else {
clientUserName = doKerberosAuth(request);
}
- } else if (HiveSamlUtils.isSamlAuthMode(authType)) {
Review comment:
should we delete HiveSamlUtils.isSamlAuthMode or atleast change it to
use authType.isEnabled()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]