vcsomor commented on a change in pull request #3032:
URL: https://github.com/apache/hive/pull/3032#discussion_r808912041
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/Metrics.java
##########
@@ -160,6 +159,47 @@ public Integer getValue() {
}
}
+ /**
+ * Get a Map that represents a multi-field metric,
+ * or create a new one if it does not already exist.
+ * @param name Name of map metric. This should come from MetricConstants
+ * @return MapMetric .
+ */
+ public static MapMetrics getOrCreateMapMetrics(String name) {
+ if (self == null) {
+ return dummyMapMetrics;
+ }
+
+ Map<String, Metric> metrics = self.registry.getMetrics();
+ Metric map = metrics.get(name);
+ if (map instanceof MapMetrics) {
Review comment:
The `instanceof` is nullsafe. if `map` is `null` the the `if` becomes
`false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
