vcsomor commented on a change in pull request #3032:
URL: https://github.com/apache/hive/pull/3032#discussion_r808916354
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/AcidMetricService.java
##########
@@ -93,12 +93,9 @@
public class AcidMetricService implements MetastoreTaskThread {
private static final Logger LOG =
LoggerFactory.getLogger(AcidMetricService.class);
- public static final String OBJECT_NAME_PREFIX =
"metrics:type=compaction,name=";
Review comment:
The `OBJECT_NAME_PREFIX` was only required for JMX exposure. Not needed
at all for the json format. All the metrics following this pattern (see the
below json).
```json
{
"version" : "1.0",
"gauges" : {
"compaction_num_workers" : {
"value" : 0
},
"compaction_num_working" : {
"value" : 0
}
},
"mbeans" : {
"compaction_num_active_deltas" : {
"db.table1/partition2" : 1000,
"db.table1/partition1" : 100
},
"compaction_num_obsolete_deltas" : {
"db.table3/partition" : 300
},
"compaction_num_small_deltas" : {
"db.table2/partition" : 200
}
}
```
As you can see the type and all the name not required at all because it i
defined by the object_key (e.g.: compaction_num_active_deltas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
