klcopp commented on a change in pull request #3126:
URL: https://github.com/apache/hive/pull/3126#discussion_r834198361
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -386,12 +384,11 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
p = resolvePartition(ci);
if (p == null && ci.partName != null) {
LOG.info("Unable to find partition " + ci.getFullPartitionName() +
- ", assuming it was dropped and moving on.");
- msc.markCleaned(CompactionInfo.compactionInfoToStruct(ci));
Review comment:
Same as above
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -364,15 +364,13 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
t1 = resolveTable(ci);
if (t1 == null) {
LOG.info("Unable to find table " + ci.getFullTableName() +
- ", assuming it was dropped and moving on.");
- msc.markCleaned(CompactionInfo.compactionInfoToStruct(ci));
Review comment:
We have to move this compaction to completed_compactions somehow. Or am
I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]