deniskuzZ commented on a change in pull request #3126:
URL: https://github.com/apache/hive/pull/3126#discussion_r834211877
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -442,31 +439,24 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
// Don't start compaction or cleaning if not necessary
if (isDynPartAbort(t, ci)) {
- msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci));
+ markWithState(ci, null, CompactionState.Compacted);
compactionTxn.wasSuccessful();
return false;
}
AcidDirectory dir = getAcidStateForWorker(ci, sd, tblValidWriteIds);
if (!isEnoughToCompact(ci.isMajorCompaction(), dir, sd)) {
if (needsCleaning(dir, sd)) {
- msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci));
+ markWithState(ci, null, CompactionState.Compacted);
} else {
- // do nothing
- msc.markCleaned(CompactionInfo.compactionInfoToStruct(ci));
+ markWithState(ci, "None of the compaction thresholds hit, compaction
request is refused!", CompactionState.Refused);
}
compactionTxn.wasSuccessful();
return false;
}
if (!ci.isMajorCompaction() &&
!isMinorCompactionSupported(t.getParameters(), dir)) {
- ci.errorMessage = String.format("Query based Minor compaction is not
possible for full acid tables having raw " +
+ markWithState(ci, String.format("Query based Minor compaction is not
possible for full acid tables having raw " +
"format (non-acid) data in them. Compaction type: %s,
Partition: %s, Compaction id: %d",
- ci.type.toString(), ci.getFullPartitionName(), ci.id);
- LOG.error(ci.errorMessage);
- try {
- msc.markRefused(CompactionInfo.compactionInfoToStruct(ci));
- } catch (Throwable tr) {
- LOG.error("Caught an exception while trying to mark compaction {} as
failed: {}", ci, tr);
- }
+ ci.type.toString(), ci.getFullPartitionName(), ci.id),
CompactionState.Refused);
Review comment:
toString() is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
