marton-bod commented on a change in pull request #3129:
URL: https://github.com/apache/hive/pull/3129#discussion_r835262573
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
##########
@@ -304,6 +304,10 @@ public static HiveStorageHandler getStorageHandler(
}
}
+ public static String getDefaultComment(HiveStorageHandler storageHandler) {
+ return storageHandler != null ? storageHandler.getDefaultColumnComment() :
HiveStorageHandler.FROM_SERIALIZER;
Review comment:
Doesn't this add "from deserializer" to native tables (where storage
handler is null)? I thought this default comment thing was only related to
non-native tables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
