pvary commented on a change in pull request #3129:
URL: https://github.com/apache/hive/pull/3129#discussion_r835283057
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
##########
@@ -304,6 +304,10 @@ public static HiveStorageHandler getStorageHandler(
}
}
+ public static String getDefaultComment(HiveStorageHandler storageHandler) {
+ return storageHandler != null ? storageHandler.getDefaultColumnComment() :
HiveStorageHandler.FROM_SERIALIZER;
Review comment:
Default storage handler still could have a `from deserializer` field.
For example AVRO files can contain the schema and they can dictate the columns
of the table. This change makes sure that we do not get an error when the
storage handler is null. The other default is handled by the default
implementation for the `getDefaultColumnComment()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
