deniskuzZ commented on code in PR #2993:
URL: https://github.com/apache/hive/pull/2993#discussion_r848054845
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadWork.java:
##########
@@ -157,10 +159,20 @@ public ReplLoadWork(HiveConf hiveConf, String
dumpDirectory,
Path incBootstrapDir = new Path(dumpDirectory,
ReplUtils.INC_BOOTSTRAP_ROOT_DIR_NAME);
if (fs.exists(incBootstrapDir)) {
if (isSecondFailover) {
- String[] tableList = getBootstrapTableList(dumpDirParent, hiveConf);
- tablesToBootstrap = Arrays.asList(tableList);
- LOG.info("Optimised bootstrap for database {} with load with
bootstrap table list as {}", dbNameToLoadIn,
+ String[] bootstrappedTables = getBootstrapTableList(new
Path(dumpDirectory).getParent(), hiveConf);
+ tablesToBootstrap = new
ArrayList<String>(Arrays.asList(bootstrappedTables));
+ LOG.info("Optimised bootstrap for database {} with load with
bootstrapped table list as {}", dbNameToLoadIn,
tablesToBootstrap);
+ ArrayList<String> tableList = new
ArrayList<String>(Arrays.asList(bootstrappedTables));
Review Comment:
oh, you are modifying the list, please disregard, however, using linkedlist
would be more efficient
new LinkedList<>(Arrays.asList(bootstrappedTables))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
