deniskuzZ commented on code in PR #2993:
URL: https://github.com/apache/hive/pull/2993#discussion_r850207685
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadWork.java:
##########
@@ -157,10 +159,20 @@ public ReplLoadWork(HiveConf hiveConf, String
dumpDirectory,
Path incBootstrapDir = new Path(dumpDirectory,
ReplUtils.INC_BOOTSTRAP_ROOT_DIR_NAME);
if (fs.exists(incBootstrapDir)) {
if (isSecondFailover) {
- String[] tableList = getBootstrapTableList(dumpDirParent, hiveConf);
- tablesToBootstrap = Arrays.asList(tableList);
- LOG.info("Optimised bootstrap for database {} with load with
bootstrap table list as {}", dbNameToLoadIn,
+ String[] bootstrappedTables = getBootstrapTableList(new
Path(dumpDirectory).getParent(), hiveConf);
+ tablesToBootstrap = new
ArrayList<String>(Arrays.asList(bootstrappedTables));
+ LOG.info("Optimised bootstrap for database {} with load with
bootstrapped table list as {}", dbNameToLoadIn,
tablesToBootstrap);
+ ArrayList<String> tableList = new
ArrayList<String>(Arrays.asList(bootstrappedTables));
+ // Get list of tables bootstrapped.
+ Path tableMetaPath = new Path(incBootstrapDir,
EximUtil.METADATA_PATH_NAME + "/" + sourceDbName);
+ FileStatus[] listing = fs.listStatus(tableMetaPath);
+ for (FileStatus tablePath : listing) {
+ tableList.remove(tablePath.getPath().getName());
+ }
+ tablesToDrop = tableList;
Review Comment:
the question was if we should keep the same table in both lists? if we add
something into tablesToDrop, should we remove it from the tablesToBootstrap?
In`testOverwriteDuringBootstrap test `tnew_managed` is added to both lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
