pvary commented on PR #3238: URL: https://github.com/apache/hive/pull/3238#issuecomment-1108447729
@zhangbutao: I think having a test would help preventing the situation when some change inadvertently reverts the fix. If writing a test is not prohibitively hard, I would suggest adding one, maybe with mocking the `DataConnectorProviderFactory` or something around that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
