zhangbutao commented on PR #3238: URL: https://github.com/apache/hive/pull/3238#issuecomment-1109504936
> I think having a test would help preventing the situation when some change inadvertently reverts the fix. If writing a test is not prohibitively hard, I would suggest adding one, maybe with mocking the `DataConnectorProviderFactory` or something around that. > @pvary Thanks for your suggestion. But i find it a little difficult to write this test. If mocking related class (`DataConnectorProviderFactory` or `IDataConnectorProvider`), we need add `powermock-api-mockito2` dependency to standalone-metastore moudle and I'm worried about the impact on existing tests. I also try add powermock dependency to mock test but found that metastore initializing not work well with `@RunWith(PowerMockRunner.class).` Because the added code snippet has been tested in `get_tables`(eg. `dataconnector_mysql.q` tested by mysql-docker), Could we skip the test here? or do you have a better way to test? thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
