[GitHub] [hive] deniskuzZ commented on a diff in pull request #3298: HIVE-26237: Check if replication cause metastore connection leakage

[GitBox]

deniskuzZ commented on code in PR #3298:
URL: https://github.com/apache/hive/pull/3298#discussion_r875776250


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java:
##########
@@ -549,8 +547,7 @@ private void createReplLoadCompleteAckTask() {
         @Override
         public void run() throws SemanticException {
           try {
-            HiveMetaStoreClient metaStoreClient = new 
HiveMetaStoreClient(conf);
-            long currentNotificationID = 
metaStoreClient.getCurrentNotificationEventId().getEventId();
+            long currentNotificationID = 
getHive().getMSC().getCurrentNotificationEventId().getEventId();

Review Comment:
   hard to read, split it on few assignments as before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org