hmangla98 commented on code in PR #3298:
URL: https://github.com/apache/hive/pull/3298#discussion_r876899781
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/BaseReplicationAcrossInstances.java:
##########
@@ -121,6 +122,7 @@ static void
internalBeforeClassSetupExclusiveReplica(Map<String, String> primary
public static void classLevelTearDown() throws IOException {
primary.close();
replica.close();
+ Hive.getThreadLocal().close(true);
Review Comment:
Agreed.
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java:
##########
@@ -262,17 +263,20 @@ public static void tearDownAfterClass(){
// FIXME : should clean up TEST_PATH, but not doing it now, for
debugging's sake
//Clean up the warehouse after test run as we are restoring the warehouse
path for other metastore creation
Path warehousePath = new Path(MetastoreConf.getVar(hconf,
MetastoreConf.ConfVars.WAREHOUSE));
- try {
- warehousePath.getFileSystem(hconf).delete(warehousePath, true);
- } catch (IOException e) {
-
- }
Path warehousePathReplica = new Path(MetastoreConf.getVar(hconfMirror,
MetastoreConf.ConfVars.WAREHOUSE));
try {
+ warehousePath.getFileSystem(hconf).delete(warehousePath, true);
warehousePathReplica.getFileSystem(hconfMirror).delete(warehousePathReplica,
true);
} catch (IOException e) {
}
+ Hive.getThreadLocal().close(true);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
