ayushtkn commented on PR #3279: URL: https://github.com/apache/hive/pull/3279#issuecomment-1130131300
>test not fully flushing/closing xml file before trying to read it? Looks like some maven issue only, it tries to compute diff between the generated query output file & the stored query output file, if the diff is empty, the test is said to be passing else failed. else it puts the diff in the xml, Guess diff has some character which is messing up the xml structure, I need to further investigate though.... > the move in 3.3.3 to reload4j might add some exclusion complications if hive is declaring its own logging classes. I just pushed a commit upgrading to 3.3.3, I haven't tested the distro, but the compilation & ran one test. Do I need to exclude reload4j from every hadoop dependency? If it creates some runtime issues, I think I am happy moving from 3.1.0 to 3.3.2 and rest wait for 3.4.0. Even if I exclude next time when I move to 3.4.x or above I need to take those changes back, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
