kgyrtkirk commented on code in PR #3279: URL: https://github.com/apache/hive/pull/3279#discussion_r885363228
########## ql/src/test/queries/clientpositive/acid_table_directories_test.q: ########## @@ -1,3 +1,5 @@ +--! qt:disabled:disabled Tests the output of LS and that changes, Not a functional test, just adds some masking logic Review Comment: you may also remove this test....and/or open a jira to remove the things which were added in HIVE-21650; I think `qt:replace` could do the same.. hmm...it seems like `hive.qtest.additional.partial.mask.pattern` is only used in this test and nowhere else... ########## ql/src/test/results/clientpositive/llap/acid_table_directories_test.q.out: ########## @@ -163,13 +170,6 @@ POSTHOOK: Input: default@acidparttbl@p=200 ### ACID DELTA DIR ### ### ACID DELTA DIR ### ### ACID DELTA DIR ### -#### A masked pattern was here #### Review Comment: I would guess the directory listing order might have changed... note: I think we should have better masking policies instead of removing the whole lines (mask only the WH part of the path)...it could be important what was the directory... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
