pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880145361
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -511,24 +515,11 @@ private static Schema readSchema(Configuration conf,
Table table, boolean caseSe
readSchema = caseSensitive ? table.schema().select(selectedColumns) :
table.schema().caseInsensitiveSelect(selectedColumns);
- Operation operation = HiveIcebergStorageHandler.operation(conf,
conf.get(Catalogs.NAME));
- if (operation != null) {
- switch (operation) {
- case DELETE:
- // for DELETE queries, add additional metadata columns into the
read schema
- return
IcebergAcidUtil.createFileReadSchemaForDelete(readSchema.columns(), table);
- case UPDATE:
- // for UPDATE queries, add additional metadata columns into the
read schema
- return
IcebergAcidUtil.createFileReadSchemaForUpdate(readSchema.columns(), table);
- case OTHER:
- // for INSERT queries no extra columns are needed
- return readSchema;
- default:
- throw new IllegalArgumentException("Not supported operation " +
operation);
- }
- } else {
- return readSchema;
+ if (InputFormatConfig.fetchVirtualColumns(conf)) {
+ return
IcebergAcidUtil.createFileReadSchemaForDelete(readSchema.columns(), table);
Review Comment:
Maybe rename the method to `createFileReadSchemaWithVirtualColums`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
