pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880148379
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -11484,14 +11484,13 @@ private Operator genTablePlan(String alias, QB qb)
throws SemanticException {
}
// put all virtual columns in RowResolver.
- if (!tab.isNonNative()) {
- for (VirtualColumn vc : VirtualColumn.getRegistry(conf)) {
- vcList.add(vc);
- rwsch.put(alias, vc.getName().toLowerCase(), new
ColumnInfo(vc.getName(),
- vc.getTypeInfo(), alias, true, vc.getIsHidden()
- ));
- }
+ vcList = VirtualColumn.getRegistry(conf);
Review Comment:
nit: The `vcList` has been declared previously. We are redefining it. Is it
ok? Shall we just use another variable, to make sure no collision happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
