pvary commented on code in PR #3367:
URL: https://github.com/apache/hive/pull/3367#discussion_r896645398
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/OptimisedBootstrapUtils.java:
##########
@@ -201,19 +262,17 @@ public static Long createAndGetEventAckFile(Path
currentDumpPath, DumpMetaData d
}
/**
- * Prepares the table diff file, with tables modified post the specified
event id.
- * @param eventId the event id after which tables should be modified
+ * Returns list of notificationEvents starting from eventId that are related
to the database.
+ * @param eventId Starting eventId
* @param hiveDb the hive object
* @param work the load work
- * @param conf hive configuration
* @throws Exception
*/
- public static void prepareTableDiffFile(Long eventId, Hive hiveDb,
ReplLoadWork work, HiveConf conf)
- throws Exception {
- // Get the notification events.
+ public static List<NotificationEvent> getListOfNotificationEvents(Long
eventId, Hive hiveDb,
+
ReplLoadWork work) throws Exception {
List<NotificationEvent> notificationEvents =
- hiveDb.getMSC().getNextNotification(eventId - 1, -1, new
DatabaseAndTableFilter(work.dbNameToLoadIn, null))
- .getEvents();
+ hiveDb.getMSC().getNextNotification(eventId - 1, -1,
+ new DatabaseAndTableFilter(work.dbNameToLoadIn,
null)).getEvents();
Review Comment:
Are these only formatting changes? We usually try to avoid these, so
backporting changes are easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
