pvary commented on code in PR #3367:
URL: https://github.com/apache/hive/pull/3367#discussion_r896652450
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -751,18 +767,19 @@ private void fetchFailoverMetadata(Hive hiveDb) throws
HiveException, IOExceptio
work.setFailoverMetadata(fmd);
return;
}
- List<Long> txnsForDb = getOpenTxns(getTxnMgr().getValidTxns(excludedTxns),
work.dbNameOrPattern);
+ HiveTxnManager hiveTxnManager = getTxnMgr();
Review Comment:
This call is not that costly, and if we use a static import for
`ReplUtils.getOpenTxns` we would have a smaller change which is easier to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
