cmunkey commented on PR #3444:
URL: https://github.com/apache/hive/pull/3444#issuecomment-1189547237
Coding standard is 2 space indents.
The unit test mainly tests the DumpExporter since the runnable does nothing.
Maybe there needs to be an integration test that makes sure that running
exports in parallel doesn't
have issues like more than one thread accessing some resource that we don't
know about.
For your existing test, maybe the multithreaded one can do a runnable like
this:
- counter that is a semaphore set to the number of currency that you want
- each runnable,
counter.tryAcquire() - should not block (return false)
sleep
counter.release()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
