cmunkey commented on PR #3444:
URL: https://github.com/apache/hive/pull/3444#issuecomment-1198524407
Ignore these comments, I added them in line instead.
> > @test(expected = HiveException.class)
> > public void testDumpExporterWithParallelismFail() throws Exception {
>
> Shouldn't the error be AssertionError? Is what's failing really what you
expected?
>
> I think this is what's wrong:
>
> > Assert.assertTrue(sem.tryAcquire());
>
> Should be different for positive vs negative test.
>
> Positive tests should be true, Negative tests should be false.
>
> Are all your other tests failing too? they may, you are catching and not
rethrowing there.
>
> This should be what's failing. assertTrue() throw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
