pvary commented on code in PR #3461:
URL: https://github.com/apache/hive/pull/3461#discussion_r927419381
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -62,11 +62,10 @@ protected ASTNode getTargetTableNode(ASTNode tree) {
@Override
public void analyze(ASTNode tree, Table targetTable, ASTNode tableNameNode)
throws SemanticException {
- if (tree.getToken().getType() != HiveParser.TOK_MERGE) {
- throw new RuntimeException("Asked to parse token " + tree.getName() + "
in " +
- "MergeSemanticAnalyzer");
+ boolean nonNativeAcid = AcidUtils.isNonNativeAcidTable(targetTable);
+ if (nonNativeAcid) {
Review Comment:
Could we create an automatic way to turn on the appropriate configs when the
query is an Iceberg query? Maybe something like
`HiveIcebergStorageHandler.fallbackToNonVectorizedModeBasedOnProperties`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
