kasakrisz commented on code in PR #3461:
URL: https://github.com/apache/hive/pull/3461#discussion_r927521734
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -62,11 +62,10 @@ protected ASTNode getTargetTableNode(ASTNode tree) {
@Override
public void analyze(ASTNode tree, Table targetTable, ASTNode tableNameNode)
throws SemanticException {
- if (tree.getToken().getType() != HiveParser.TOK_MERGE) {
- throw new RuntimeException("Asked to parse token " + tree.getName() + "
in " +
- "MergeSemanticAnalyzer");
+ boolean nonNativeAcid = AcidUtils.isNonNativeAcidTable(targetTable);
+ if (nonNativeAcid) {
Review Comment:
It is already implemented and used independently from this patch.
`HiveIcebergStorageHandler.fallbackToNonVectorizedModeBasedOnProperties` is
called when FSOperator "augments the plan"
https://github.com/apache/hive/blob/4146d220bfc0a29d117676844a4c7021fcc6a30d/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java#L1612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
