deniskuzZ commented on code in PR #3550:
URL: https://github.com/apache/hive/pull/3550#discussion_r958098400
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -2265,6 +2268,55 @@ public static Boolean isToInsertOnlyTable(Table tbl,
Map<String, String> props)
return true;
}
+ public static Boolean isToFullAcid(Table table, Map<String, String> props) {
+ String transactional =
props.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
+ String transactionalProp =
props.get(hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES);
+
+ if (transactional == null && transactionalProp == null) {
+ // Not affected or the op is not about transactional.
+ return false;
+ } else if (transactional == null && table != null) {
+ transactional =
table.getParameters().get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
+ }
+
+ if (transactionalProp == null) {
+ boolean isSetToTxn = "true".equalsIgnoreCase(transactional);
+ if (isSetToTxn || table == null) return false; // Assume the full ACID
table.
+ throw new RuntimeException("Cannot change '" +
hive_metastoreConstants.TABLE_IS_TRANSACTIONAL
+ + "' without '" +
hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES + "'");
+ }
+
+ if (table == null) return false;
+
+ StorageDescriptor sd = table.getSd();
+ return isAcidInputOutputFormat(table.getTableName(), table.getSd()) &&
sd.getSortColsSize() <= 0;
Review Comment:
should we expose `canBeMadeAcid` to avoid code duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
