deniskuzZ commented on code in PR #3550:
URL: https://github.com/apache/hive/pull/3550#discussion_r958115380
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -2265,6 +2268,55 @@ public static Boolean isToInsertOnlyTable(Table tbl,
Map<String, String> props)
return true;
}
+ public static Boolean isToFullAcid(Table table, Map<String, String> props) {
+ String transactional =
props.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
Review Comment:
can we simplify this a bit?
````
if (table == null || !TxnUtils.isTransactionalTable(props)) {
return false;
}
````
I don't understand how it's possible that transactionalProp!= null, but
transactional = null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
