veghlaci05 commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r959272274
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7036,4 +7036,15 @@ public void syncFromConf(HiveConf conf) {
set(e.getKey(), e.getValue());
}
}
+
+ public List<RegexMatchingConfEntry> getMatchingEntries(Pattern regex) {
+ List<RegexMatchingConfEntry> matchingEntries = new ArrayList<>();
+ for (Map.Entry<String, String> entry : this) {
+ Matcher matcher = regex.matcher(entry.getKey());
+ if (matcher.matches()) {
+ matchingEntries.add(new RegexMatchingConfEntry(entry.getKey(),
matcher));
Review Comment:
Both the key and the created matcher are required in HiveServer2 class as
well. I crated this wrapper In order to save resources by preventing the
re-creation of the matcher there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]