deniskuzZ commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r959600648
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -237,14 +244,18 @@ public void run() {
}
}
- private void scheduleCompactionIfRequired(CompactionInfo ci, Table t,
Partition p, String runAs, boolean metricsEnabled)
+ private void scheduleCompactionIfRequired(CompactionInfo ci, Database d,
Table t, Partition p, String runAs, boolean metricsEnabled)
throws MetaException {
StorageDescriptor sd = resolveStorageDescriptor(t, p);
try {
ValidWriteIdList validWriteIds = resolveValidWriteIds(t);
CompactionType type = checkForCompaction(ci, validWriteIds, sd,
t.getParameters(), runAs);
if (type != null) {
ci.type = type;
+ ci.poolName =
t.getParameters().get(Constants.HIVE_COMPACTOR_WORKER_POOL);
Review Comment:
could we extract this logic into a separate method, like getPoolName, and
pass it as param to scheduleCompactionIfRequired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
