dengzhhu653 commented on code in PR #3621:
URL: https://github.com/apache/hive/pull/3621#discussion_r980666461
##########
service/src/test/org/apache/hive/service/cli/operation/TestOperationLogManager.java:
##########
@@ -61,6 +60,7 @@ public void setUp() throws Exception {
HiveConf.setIntVar(hiveConf,
HiveConf.ConfVars.HIVE_SERVER2_WEBUI_MAX_HISTORIC_QUERIES, 1);
HiveConf.setIntVar(hiveConf, HiveConf.ConfVars.HIVE_SERVER2_WEBUI_PORT,
8080);
HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_IN_TEST, true);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_TESTING_REMOVE_LOGS,
false);
Review Comment:
why this property should set to false when
HIVE_SERVER2_HISTORIC_OPERATION_LOG_ENABLED is enabled? we do not want to set
this in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
