dengzhhu653 commented on code in PR #3621:
URL: https://github.com/apache/hive/pull/3621#discussion_r980668220
##########
service/src/java/org/apache/hive/service/cli/operation/Operation.java:
##########
@@ -314,12 +318,13 @@ protected synchronized void cleanupOperationLog(final
long operationLogCleanupDe
} else {
if (operationLogCleanupDelayMs > 0) {
ScheduledExecutorService scheduledExecutorService =
Executors.newScheduledThreadPool(1);
- scheduledExecutorService.schedule(new
OperationLogCleaner(operationLog), operationLogCleanupDelayMs,
+ scheduledExecutorService.schedule(new OperationLogCleaner(this,
operationLog), operationLogCleanupDelayMs,
TimeUnit.MILLISECONDS);
scheduledExecutorService.shutdown();
} else {
log.info("Closing operation log {} without delay", operationLog);
operationLog.close();
+ OperationLogManager.closeOperation(this);
Review Comment:
nit: can we put `OperationLogManager.closeOperation(this)` into
`operationLog.close()`? so we can only take care of SQLOperation's log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
