szlta commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r980905190
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedInputFormatInterface.java:
##########
@@ -18,11 +18,15 @@
package org.apache.hadoop.hive.ql.exec.vector;
+import org.apache.hadoop.hive.conf.HiveConf;
+
+import java.util.Properties;
+
/**
* Marker interface to indicate a given input format supports
* vectorization input.
*/
public interface VectorizedInputFormatInterface {
- VectorizedSupport.Support[] getSupportedFeatures();
+ VectorizedSupport.Support[] getSupportedFeatures(HiveConf hiveConf,
Properties properties);
Review Comment:
To reduce the scope of the required refactoring. We could add this as a new
method while keeping the old one too.
```
VectorizedSupport.Support[] getSupportedFeatures();
+ default VectorizedSupport.Support[] getSupportedFeatures(HiveConf
hiveConf, Properties properties) {
+ return getSupportedFeatures();
+ }
```
And then in HiveIcebergInputFormat we could have something like:
```
+ public VectorizedSupport.Support[] getSupportedFeatures() {
+ throw new UnsupportedOperationException("This overload of
getSupportedFeatures should never be called");
+ }
+ public VectorizedSupport.Support[] getSupportedFeatures(HiveConf hiveConf,
Properties properties) {
+ //do the logic you have implemented
+ }
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
