szlta commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r983438232
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -125,6 +125,7 @@ public class HiveIcebergMetaHook implements HiveMetaHook {
private static final List<org.apache.commons.lang3.tuple.Pair<Integer,
byte[]>> EMPTY_FILTER =
Lists.newArrayList(org.apache.commons.lang3.tuple.Pair.of(1, new
byte[0]));
static final String MIGRATED_TO_ICEBERG = "MIGRATED_TO_ICEBERG";
+ static final String ORC_FILES_ONLY = "orc.files.only";
Review Comment:
This is probably ends being an Iceberg-Hive integration logic only, and thus
perhaps we should prepend this with "iceberg" so it's `iceberg.orc.files.only`
or something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
