deniskuzZ commented on code in PR #3625:
URL: https://github.com/apache/hive/pull/3625#discussion_r984573898
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -314,6 +314,8 @@ abstract class TxnHandler implements TxnStore,
TxnStore.MutexAPI {
private static final String EXCL_CTAS_ERR_MSG =
"Failed to initiate a concurrent CTAS operation with the same table
name, lockInfo : %s";
private static final String ZERO_WAIT_READ_ERR_MSG = "Unable to acquire read
lock due to an existing exclusive lock {%s}";
+ private static String SHOW_COMPACTION_ORDERBY_CLAUSE = " order by case
when CC_END > CC_START and CC_END > CC_ENQUEUE_TIME then CC_END When CC_START >
CC_ENQUEUE_TIME then CC_START Else CC_ENQUEUE_TIME end desc";
Review Comment:
CC_ENQUEUE_TIME - inserted in a queue;
CC_START - worker started;
CC_COMMIT_TIME - end of worker/compaction
CQ_CLEANER_START - cleaner started
CC_END - end of cleaner
shouldn't it be something like:
````
order by
case
when CC_END > CC_START and CC_END > CC_COMMIT_TIME
then CC_END
when CC_START > CC_COMMIT_TIME
then CC_START
else CC_COMMIT_TIME
end desc,
CC_ENQUEUE_TIME asc;
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
