deniskuzZ commented on code in PR #3625:
URL: https://github.com/apache/hive/pull/3625#discussion_r992431232
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -4009,6 +3983,25 @@ public ShowCompactResponse
showCompact(ShowCompactRequest rqst) throws MetaExcep
}
}
+ private List<String> getShowCompactionQueryParamList(ShowCompactRequest
request) throws MetaException {
+
+ String poolName = request.getPoolName();
+ List<String> params = new ArrayList<>();
+ if (org.apache.commons.lang3.StringUtils.isNotBlank(poolName)) {
+ params.add(poolName);
+ }
+ return params;
+ }
+
+ private String getShowCompactionFilterClause(ShowCompactRequest request) {
+ StringBuilder filter = new StringBuilder();
+ String poolName = request.getPoolName();
+ if(poolName != null && !poolName.isEmpty()){
Review Comment:
nit: space,
also you could use StringUtils.isEmpty instead of those 2 cheks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
