deniskuzZ commented on code in PR #3656:
URL: https://github.com/apache/hive/pull/3656#discussion_r999190297
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5085,16 +5087,21 @@ private int abortTxns(Connection dbConn, List<Long>
txnids, boolean checkHeartbe
StringBuilder prefix = new StringBuilder();
StringBuilder suffix = new StringBuilder();
- // add update txns queries to query list
- prefix.append("UPDATE \"TXNS\" SET \"TXN_STATE\" =
").append(TxnStatus.ABORTED)
- .append(" WHERE \"TXN_STATE\" =
").append(TxnStatus.OPEN).append(" AND ");
if (checkHeartbeat) {
- suffix.append(" AND \"TXN_LAST_HEARTBEAT\" < ")
- .append(getEpochFn(dbProduct)).append("-").append(timeout);
+ LOG.info(TxnErrorMsg.ABORT_TIMEOUT.toString() + timeout);
Review Comment:
can we keep the generic part and just add extra stuff under the if section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
