deniskuzZ commented on code in PR #3656:
URL: https://github.com/apache/hive/pull/3656#discussion_r999193525
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1023,6 +1023,7 @@ public void abortTxn(AbortTxnRequest rqst) throws
NoSuchTxnException, MetaExcept
long sourceTxnId = -1;
boolean isReplayedReplTxn =
TxnType.REPL_CREATED.equals(rqst.getTxn_type());
boolean isHiveReplTxn = rqst.isSetReplPolicy() &&
TxnType.DEFAULT.equals(rqst.getTxn_type());
+ String abrotMsg = (!rqst.isSetErrorMessage() && rqst.isSetTxnid())?
TxnErrorMsg.ABORT_QUERY.name():rqst.getErrorMessage();
Review Comment:
why do we need to check for the txnId here? In thrift, txnid is set as
mandatory
````
struct AbortTxnRequest {
1: required i64 txnid,
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
