dengzhhu653 commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1024830177
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2602,21 +2665,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name_with_environment_context(1:string
db_name, 2:string tbl_name,
3:string part_name, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_by_name_req(1:AppendPartitionRequest
appendPartitionRequest)
Review Comment:
this method takes the same parameter and throws the same exceptions as the
`append_partition_req` , so I think we can just leave only one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
