saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1029969026


##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2602,21 +2665,29 @@ service ThriftHiveMetastore extends 
fb303.FacebookService
   Partition append_partition_with_environment_context(1:string db_name, 
2:string tbl_name,
       3:list<string> part_vals, 4:EnvironmentContext environment_context)
                        throws (1:InvalidObjectException o1, 
2:AlreadyExistsException o2, 3:MetaException o3)
+  Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+                       throws (1:InvalidObjectException o1, 
2:AlreadyExistsException o2, 3:MetaException o3)
   Partition append_partition_by_name(1:string db_name, 2:string tbl_name, 
3:string part_name)
                        throws (1:InvalidObjectException o1, 
2:AlreadyExistsException o2, 3:MetaException o3)
   Partition append_partition_by_name_with_environment_context(1:string 
db_name, 2:string tbl_name,
       3:string part_name, 4:EnvironmentContext environment_context)
                        throws (1:InvalidObjectException o1, 
2:AlreadyExistsException o2, 3:MetaException o3)
+  Partition append_partition_by_name_req(1:AppendPartitionRequest 
appendPartitionRequest)
+        throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2, 
3:MetaException o3)
   bool drop_partition(1:string db_name, 2:string tbl_name, 3:list<string> 
part_vals, 4:bool deleteData)
                        throws(1:NoSuchObjectException o1, 2:MetaException o2)
   bool drop_partition_with_environment_context(1:string db_name, 2:string 
tbl_name,
       3:list<string> part_vals, 4:bool deleteData, 5:EnvironmentContext 
environment_context)
                        throws(1:NoSuchObjectException o1, 2:MetaException o2)
+  bool drop_partition_req(1:DropPartitionRequest dropPartitionReq)
+                       throws(1:NoSuchObjectException o1, 2:MetaException o2)
   bool drop_partition_by_name(1:string db_name, 2:string tbl_name, 3:string 
part_name, 4:bool deleteData)
                        throws(1:NoSuchObjectException o1, 2:MetaException o2)
   bool drop_partition_by_name_with_environment_context(1:string db_name, 
2:string tbl_name,
       3:string part_name, 4:bool deleteData, 5:EnvironmentContext 
environment_context)
                        throws(1:NoSuchObjectException o1, 2:MetaException o2)
+  bool drop_partition_by_name_req(1:DropPartitionRequest dropPartitionReq)

Review Comment:
   Yeah but both the APIs does different things. we cannot club both the APIs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to