tthorpeIBM opened a new pull request, #3799:
URL: https://github.com/apache/hive/pull/3799

   ### What changes were proposed in this pull request?
   This PR assumes that if ConfVars.USE_CUSTOM_RDBMS is set that we will expect 
DbType.CUSTOM, therefore, it will not use DbType.UNDEFINED to compare to the 
database type set in theDatabaseProduct.
   
   ### Why are the changes needed?
   getDbType(productName) returns DbType.UNDEFINED
   But when theDatabaseProduct == null and ConfVars.USE_CUSTOM_RDBMS is set  
theDatabaseProduct.dbType is initialized to DbType.CUSTOM.  DbType.UNDEFINED 
will never equal  DbType.CUSTOM
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   I compile the code, added a subclass of DatabaseProduct for Db2 and 
installed Hive Metastore using a backend Db2 database.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to